Zaki/Password-Manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(autofill): unregister new-entry hotkey during SendInput (chord fire)

Browse Source 
Ctrl+Shift+P (password autofill) with Ctrl+Shift physically held triggered
new-entry: the clear-field step injects a real Ctrl+A, and the held modifiers
(re-pressed by keyboard auto-repeat faster than ForceReleaseModifiers clears
them) make the system see Ctrl+Shift+A = our new-entry global hotkey. Injected
keys are only Ctrl+A + Tab, and only 'A' matches a hotkey, so unregister
NEW_ENTRY around the SendInput (try/finally re-register) — no WM_HOTKEY is
generated. Password/username go as VK_PACKET unicode, can't chord.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
r-zakarya
2026-07-21 19:24:09 +01:00
parent 5799407f55
commit a8e0a3da00
1 changed files with 34 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
delphi-backend/Source/PM.Bridge.pas
+34 -21
View File
@@ -1315,32 +1315,45 @@ begin
// Past every bail-out — the keystrokes below are the fill itself.
Result := True;
// Username-only: type just the username into the focused field, no Tab,
// no password. Used by the quick-search right-click / Shift+Enter path.
if AUsernameOnly then
begin
// Our own new-entry hotkey is Ctrl+Shift+A. The clear-field step injects a
// real Ctrl+A; if the user still physically holds Ctrl+Shift (they just
// pressed the autofill hotkey, and auto-repeat re-presses the modifiers
// faster than ForceReleaseModifiers can clear them), the system sees
// Ctrl+Shift+A and fires new-entry mid-fill. Unregister it for the duration
// of the SendInput so no WM_HOTKEY is generated; re-register in finally.
UnregisterHotKey(FMsgWindow, NEW_ENTRY_HOTKEY_ID);
try
// Username-only: type just the username into the focused field, no Tab,
// no password. Used by the quick-search right-click / Shift+Enter path.
if AUsernameOnly then
begin
ClearFieldIfWanted;
SendUnicodeString(AUsername);
Exit;
end;
if AUsername = '' then
begin
ClearFieldIfWanted;
SendUnicodeString(APassword);
Exit;
end;
ClearFieldIfWanted;
SendUnicodeString(AUsername);
Exit;
end;
if AUsername = '' then
begin
Sleep(200);
// Real-VK send: a physically held Shift here turns Tab into Shift+Tab —
// focus moves BACKWARD and the password lands in the username field.
ForceReleaseModifiers;
SendVKey(VK_TAB);
Sleep(200);
ClearFieldIfWanted;
SendUnicodeString(APassword);
Exit;
finally
if FNewEntryHotkeyRegistered then
RegisterHotKey(FMsgWindow, NEW_ENTRY_HOTKEY_ID,
AF_MOD_CONTROL or AF_MOD_SHIFT, Ord('A'));
end;
ClearFieldIfWanted;
SendUnicodeString(AUsername);
Sleep(200);
// Real-VK send: a physically held Shift here turns Tab into Shift+Tab —
// focus moves BACKWARD and the password lands in the username field.
ForceReleaseModifiers;
SendVKey(VK_TAB);
Sleep(200);
ClearFieldIfWanted;
SendUnicodeString(APassword);
end;
end.