Zaki/Password-Manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(db): enable SQLite foreign_keys explicitly (audit 6c-9)

Browse Source 
SQLite defaults foreign_keys OFF per connection, and the schema relies on
ON DELETE CASCADE (entry_attachments, entries_password_history, recovery_keys).
FireDAC is said to default it On but that's undocumented here — set
ForeignKeys=On so a permanent delete never orphans encrypted blobs. Correct
in both cases (no-op if already On). Base check before fix: 0 orphans.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
r-zakarya
2026-07-20 05:33:46 +01:00
parent 19b66b7bbd
commit 2e7aebf651
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
delphi-backend/Source/PM.Database.pas
+6
View File
@@ -83,6 +83,12 @@ begin
FConn.Params.Values['Synchronous'] := 'Normal';
FConn.Params.Values['BusyTimeout'] := '5000';
FConn.Params.Values['JournalMode'] := 'WAL';
// Explicit ON: SQLite defaults foreign_keys OFF per-connection, and the
// schema relies on ON DELETE CASCADE (entry_attachments, entries_password_
// history, recovery_keys on user/entry delete). FireDAC is *said* to default
// this On but it's undocumented for us — set it so a permanent delete never
// leaves orphaned encrypted blobs. No-op if it was already On (§6c-9).
FConn.Params.Values['ForeignKeys'] := 'On';
FConn.Open;
CreateSchema;
ApplyMigrations;