From 1751f0534f7a04fea534c252aa0116f3b733775e Mon Sep 17 00:00:00 2001 From: r-zakarya <82443831+r-zakarya@users.noreply.github.com> Date: Mon, 13 Jul 2026 04:57:20 +0100 Subject: [PATCH] fix(slideover): opening the editor closes Settings (was hidden underneath) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Ctrl+Shift+A with Settings open created the entry panel BELOW the Settings panel — invisible. openSlideOver now closes Settings first (root fix: covers every editor-open path, not just the hotkey), placed after the discard guard so cancelling keeps Settings. The inverse — opening Settings over the editor — stays as-is by design (Esc: Settings first, editor second). Co-Authored-By: Claude Opus 4.8 --- js/app.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/js/app.js b/js/app.js index 53171d6..578ebc7 100644 --- a/js/app.js +++ b/js/app.js @@ -3850,6 +3850,14 @@ async function openSlideOver(id, opts) { } if (!isNew && !e) return; + // The editor must be visible when it opens: Settings sits ABOVE the + // slideover, so a hotkey (Ctrl+Shift+A) fired with Settings open left + // the new-entry panel hidden underneath. Close Settings — placed AFTER + // the discard guard so cancelling it keeps Settings untouched. The + // inverse (opening Settings over the editor) is deliberate and stays: + // Esc closes Settings first, then handles the editor. + if ($('#settingsPanel').classList.contains('is-open')) closeSettings(); + state.selectedId = isNew ? null : id; if (!isNew) touchEntry(id); // Templates: resolve a preset bundle of {kind, title, customFields,