refactor: remove the dead legacy entry modal

openEntryModal had zero callers — the slideover editor replaced it — but the
whole cluster still shipped: the #entryModal markup, saveEntry (wired to the
form submit), closeEntryModal, populateFolderSelect, updateEntryStrength, and
the entire tag-chip subsystem (editingTags, renderChips, addTag, the suggest
dropdown) plus their init wirings and the Esc-chain branch.

saveEntry was a latent hazard: still bound to #entryForm submit, it did a
PARTIAL PUT (no kind / totp_secret / custom_fields / template) — the exact
silent-data-loss bug moveEntryToFolder documents. Unreachable today, but one
stray call away from wiping fields.

Removed JS + HTML + the orphaned .chip-suggestion CSS. The generator is shared
with the slideover — kept; its dead 'entry' target branch collapsed to
slideover-only. 322 lines gone, tests green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
r-zakarya
2026-07-25 14:35:39 +01:00
parent d101192e22
commit 0434eec85e
3 changed files with 6 additions and 328 deletions
-21
View File
@@ -368,27 +368,6 @@ input[type="range"]::-webkit-slider-thumb {
.chip button:hover { opacity: 1; background: rgba(0,0,0,0.1); }
.chip button svg { width: 10px; height: 10px; }
/* Tag suggestions dropdown */
.chip-suggestions {
position: absolute;
z-index: 50;
background: var(--bg-elev);
border: 1px solid var(--border);
border-radius: var(--radius-sm);
box-shadow: var(--shadow);
padding: 4px;
max-height: 200px;
overflow-y: auto;
min-width: 160px;
}
.chip-suggestion {
padding: 6px 10px;
border-radius: 6px;
font-size: 12px;
cursor: pointer;
}
.chip-suggestion:hover, .chip-suggestion.is-active { background: var(--bg-elev-2); color: var(--text); }
.chip-suggestion-empty { padding: 6px 10px; color: var(--text-faint); font-size: 12px; }
/* Settings rows */
.setting-row {